Open
Conversation
… successfully being replaced the old value is still searchable
CheezItMan
reviewed
Feb 27, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Really nice work, you hit most of the learning goals here. Very elegantly written code. The only issue is with height, as it's not quite working. Check out my comments and let me know any questions you have.
Comment on lines
+19
to
21
| # Time Complexity: log(n) | ||
| # Space Complexity: log(n) | ||
| def add(key, value) |
Comment on lines
+43
to
45
| # Time Complexity: log(n) | ||
| # Space Complexity: log(n) | ||
| def find(key) |
| end | ||
| end | ||
|
|
||
| def delete(key) |
|
|
||
| def remove(node) | ||
| if node.left.nil? && node.right.nil? | ||
| node = nil |
There was a problem hiding this comment.
This only changes the local variable (node) reference.
Comment on lines
+114
to
116
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def inorder |
Comment on lines
+130
to
132
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def preorder |
Comment on lines
+144
to
146
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def postorder |
Comment on lines
+158
to
160
| # Time Complexity: O(n) | ||
| # Space Complexity: O(log n) | ||
| def height |
There was a problem hiding this comment.
This method isn't actually working. See my note below.
Think about this:
If the node is nil then return 0
If the node is not 0, find the height of the left and the right.
Return the height of the bigger subtree and add one (for the current node).
lib/tree.rb
Outdated
| end | ||
|
|
||
| height_helper(node.left, left + 1, right) | ||
| height_helper(node.right, left, right + 1) |
There was a problem hiding this comment.
This is only returning the right side's height!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.